Apache9 commented on code in PR #8219:
URL: https://github.com/apache/hbase/pull/8219#discussion_r3254861766
##########
hbase-common/src/test/java/org/apache/hadoop/hbase/io/compress/TestCodecPool.java:
##########
@@ -42,55 +41,51 @@
import org.apache.hadoop.io.compress.DefaultCodec;
import org.apache.hadoop.io.compress.GzipCodec;
import org.apache.hadoop.io.compress.zlib.BuiltInGzipDecompressor;
-import org.junit.Before;
-import org.junit.BeforeClass;
-import org.junit.ClassRule;
-import org.junit.Test;
-import org.junit.experimental.categories.Category;
+import org.junit.jupiter.api.BeforeAll;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Tag;
+import org.junit.jupiter.api.Test;
/**
* Along with CodecPool, this is copied from the class of the same name in
hadoop-common. Modified
* to accommodate changes to HBase's CodecPool.
*/
-@Category({ MiscTests.class, SmallTests.class })
+@Tag(MiscTests.TAG)
+@Tag(SmallTests.TAG)
public class TestCodecPool {
- @ClassRule
- public static final HBaseClassTestRule CLASS_RULE =
- HBaseClassTestRule.forClass(TestCodecPool.class);
-
private final String LEASE_COUNT_ERR = "Incorrect number of leased
(de)compressors";
DefaultCodec codec;
- @BeforeClass
+ @BeforeAll
public static void beforeClass() {
CodecPool.initLeaseCounting();
}
- @Before
+ @BeforeEach
public void setup() {
this.codec = new DefaultCodec();
this.codec.setConf(new Configuration());
}
- @Test(timeout = 10000)
+ @Test
Review Comment:
This is not necessary, we only want to have a timeout on class level,
setting by the test Tag.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
