Umeshkumar9414 commented on code in PR #8192:
URL: https://github.com/apache/hbase/pull/8192#discussion_r3299674275


##########
hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java:
##########
@@ -980,11 +980,14 @@ public synchronized boolean isServerDead(ServerName 
serverName) {
   /**
    * Check if a server is unknown. A server can be online, or known to be 
dead, or unknown to this
    * manager (i.e, not online, not known to be dead either; it is simply not 
tracked by the master
-   * any more, for example, a very old previous instance).
+   * any more, for example, a very old previous instance). A null serverName 
should not be
+   * considered unknown. We set regionLocation null before finding the assign 
candidate (in-between
+   * region transition) or while marking it OFFLINE/FAILED_OPEN For more info 
regarding null-check
+   * in this refer HBASE-30142

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to