[ 
https://issues.apache.org/jira/browse/HBASE-30195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18085360#comment-18085360
 ] 

Andrew Kyle Purtell edited comment on HBASE-30195 at 6/1/26 11:10 PM:
----------------------------------------------------------------------

The PR has to remain a draft until an updated `hbase-thirdparty` ships. 

I applied this locally and built with {{-Dthrift.version=4.1.14-SNAPSHOT}} and 
the test results look good. 

Tests run: 155, Failures: 0, Errors: 2, Skipped: 0 * Small + medium: 
TestCallQueue (18), TestBindExceptionHandling (2), 
TestThriftHBaseServiceHandlerWithReadOnly (15), 
TestThriftHBaseServiceHandlerWithLabels (8) — all pass.
 * Large: TestThriftServer (5), TestThriftHttpServer (3), 
TestThrift2ServerCmdLine (32), TestThriftServerCmdLine (32) — all pass (the 
long HTTP/Kerberos-fallback ones too, exercising the patched {{THttpClient}} + 
{{{}TServlet{}}}).
 * The 2 errors are {{TestThriftSpnegoHttpFallbackServer}} / 
{{TestThriftSpnegoHttpServer}} failing on {{NoMatchingRule: No rules applied to 
[email protected]}} — environmental Kerberos principal mapping

The two failures are simply because Kerberos tests using the miniKDC don't 
install matching rules to handle real kerberos credentials that might be found 
in a user's environment. I recently fixed that issue in the Phoenix tests and 
will follow up for HBase on another JIRA.


was (Author: apurtell):
The PR has to remain a draft until an updated `hbase-thirdparty` ships. 

I applied this locally and built with `-Dthrift.version=4.1.14-SNAPSHOT` and 
the test results look good. 

Tests run: 155, Failures: 0, Errors: 2, Skipped: 0 * Small + medium: 
TestCallQueue (18), TestBindExceptionHandling (2), 
TestThriftHBaseServiceHandlerWithReadOnly (15), 
TestThriftHBaseServiceHandlerWithLabels (8) — all pass.
 * Large: TestThriftServer (5), TestThriftHttpServer (3), 
TestThrift2ServerCmdLine (32), TestThriftServerCmdLine (32) — all pass (the 
long HTTP/Kerberos-fallback ones too, exercising the patched {{THttpClient}} + 
{{{}TServlet{}}}).
 * The 2 errors are {{TestThriftSpnegoHttpFallbackServer}} / 
{{TestThriftSpnegoHttpServer}} failing on {{NoMatchingRule: No rules applied to 
[email protected]}} — environmental Kerberos principal mapping

The two failures are simply because Kerberos tests using the miniKDC don't 
install matching rules to handle real kerberos credentials that might be found 
in a user's environment. I recently fixed that issue in the Phoenix tests and 
will follow up for HBase on another JIRA.

> Update Thrift gateway to use new hbase-shaded-thrift in thirdparty
> ------------------------------------------------------------------
>
>                 Key: HBASE-30195
>                 URL: https://issues.apache.org/jira/browse/HBASE-30195
>             Project: HBase
>          Issue Type: Task
>            Reporter: Andrew Kyle Purtell
>            Assignee: Andrew Kyle Purtell
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 3.0.0, 4.0.0-alpha-1, 2.7.0, 2.5.15, 2.6.6
>
>
> Update Thrift gateway to use new hbase-shaded-thrift in thirdparty after 
> HBASE-30194. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to