apurtell commented on code in PR #160: URL: https://github.com/apache/hbase-thirdparty/pull/160#discussion_r3351947135
########## hbase-shaded-thrift/pom.xml: ########## @@ -0,0 +1,227 @@ +<?xml version="1.0" encoding="UTF-8"?> +<project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd";> + <!-- +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +--> + <modelVersion>4.0.0</modelVersion> + <parent> + <groupId>org.apache.hbase.thirdparty</groupId> + <artifactId>hbase-thirdparty</artifactId> + <version>${revision}</version> + <relativePath>..</relativePath> + </parent> + <artifactId>hbase-shaded-thrift</artifactId> + <name>Apache HBase Patched and Relocated (Shaded) Thrift</name> + <description>Pulls down libthrift, patches it, compiles, and then relocates/shades.</description> + <properties> + <!-- Override parent's JDK 17 settings to force JDK 8 for hbase-shaded-thrift, matching the + other source-distribution shaded modules in this project (e.g. hbase-shaded-protobuf). The + patches we apply put libthrift back on the javax.servlet and Apache HttpClient 4.x surface, + which are Java 8 friendly. --> + <toolchain.jdk.version>${hbase.unsafe.and.protobuf.java.version}</toolchain.jdk.version> + <maven.compiler.source>${java.release.version}</maven.compiler.source> + <maven.compiler.target>${java.release.version}</maven.compiler.target> + </properties> + <!-- + The patched libthrift sources reference slf4j-api, javax.servlet-api, Apache HttpClient/Core + 4.x, and commons-lang3 at compile time. These are NOT shaded; downstream consumers must + provide their own runtime versions (hbase-thrift already does). We declare them as provided + scope so they participate in compilation but never get bundled into the shaded jar. + --> + <dependencies> + <dependency> + <groupId>org.slf4j</groupId> + <artifactId>slf4j-api</artifactId> + <version>1.7.36</version> + <scope>provided</scope> + </dependency> + <dependency> + <groupId>javax.servlet</groupId> + <artifactId>javax.servlet-api</artifactId> + <version>3.1.0</version> Review Comment: Yes, will update -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
