[ https://issues.apache.org/jira/browse/HBASE-6651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13448874#comment-13448874 ]
stack commented on HBASE-6651: ------------------------------ @Hiroshi Thank you for digging in here. ThreadLocalPool was added by HBASE-2938 a while back. On #1, what do you see as implications? If its a pool of threads and all are using threadlocal, what would they need to share info? Can you say more on points #2 and #3 above? What do you suggest we do? Purge ThreadLocalPool? Thanks. > Thread safety of HTablePool is doubtful > --------------------------------------- > > Key: HBASE-6651 > URL: https://issues.apache.org/jira/browse/HBASE-6651 > Project: HBase > Issue Type: Bug > Components: client > Affects Versions: 0.94.1 > Reporter: Hiroshi Ikeda > Priority: Minor > > There are some operations in HTablePool to access to PoolMap in multiple > times without any explict synchronization. > For example HTablePool.closeTablePool() calles PoolMap.values(), and calles > PoolMap.remove(). If other threads add new instances to the pool in the > middle of the calls, the new added instances might be dropped. > (HTablePool.closeTablePool() also has another problem that calling it by > multple threads causes accessing HTable by multiple threads.) > Moreover, PoolMap is not thread safe for the same reason. > For example PoolMap.put() calles ConcurrentMap.get() and calles > ConcurrentMap.put(). If other threads add a new instance to the concurent map > in the middle of the calls, the new instance might be dropped. > And also implementations of Pool have the same problems. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira