[
https://issues.apache.org/jira/browse/HBASE-30217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xiao Liu updated HBASE-30217:
-----------------------------
Description:
{{HRegionFileSystem.getRegionId(Path)}} and
{{isTemporaryDirectoryName(String)}} were introduced in HBASE-28469 for
{{DataTieringManager}} to resolve region from HFile paths. After HBASE-29727
refactored {{BlockCacheKey}} to carry region/cf/file names directly,
{{DataTieringManager}} no longer calls these methods, leaving them as dead code.
Additionally, {{REGION_SPLITS_DIR}} (.splits) and {{REGION_MERGES_DIR}}
(.merges) constants have not been used since HBASE-26187, which changed
splits/merges to write directly into the daughter/merged region directory under
the table dir.
This patch:
* Removes unused {{getRegionId(Path)}} and {{isTemporaryDirectoryName(String)}}
* Marks {{REGION_SPLITS_DIR}} and {{REGION_MERGES_DIR}} as {{@Deprecated}}
(since 3.0.0, will be removed in 4.0.0)
was:
{\{HRegionFileSystem.getRegionId(Path)}} and
\{{isTemporaryDirectoryName(String)}} were introduced in HBASE-28469 for
\{{DataTieringManager}} to resolve region from HFile paths. After HBASE-29727
refactored \{{BlockCacheKey}} to carry region/cf/file names directly,
\{{DataTieringManager}} no longer calls these methods, leaving them as dead
code.
Additionally, \{{REGION_SPLITS_DIR}} (.splits) and \{{REGION_MERGES_DIR}}
(.merges) constants have not been used since HBASE-26187, which changed
splits/merges to write directly into the daughter/merged region directory under
the table dir.
This patch:
{quote}* Removes unused \{{getRegionId(Path)}} and
\{{isTemporaryDirectoryName(String)}}
* Marks \{{REGION_SPLITS_DIR}} and \{{REGION_MERGES_DIR}} as \{{@Deprecated}}
(since 3.0.0, will be removed in 4.0.0)
> Remove dead code getRegionId and isTemporaryDirectoryName in HRegionFileSystem
> ------------------------------------------------------------------------------
>
> Key: HBASE-30217
> URL: https://issues.apache.org/jira/browse/HBASE-30217
> Project: HBase
> Issue Type: Improvement
> Reporter: Xiao Liu
> Assignee: Xiao Liu
> Priority: Major
> Fix For: 2.7.0, 3.0.0-beta-2, 2.5.16, 2.6.7
>
>
> {{HRegionFileSystem.getRegionId(Path)}} and
> {{isTemporaryDirectoryName(String)}} were introduced in HBASE-28469 for
> {{DataTieringManager}} to resolve region from HFile paths. After HBASE-29727
> refactored {{BlockCacheKey}} to carry region/cf/file names directly,
> {{DataTieringManager}} no longer calls these methods, leaving them as dead
> code.
> Additionally, {{REGION_SPLITS_DIR}} (.splits) and {{REGION_MERGES_DIR}}
> (.merges) constants have not been used since HBASE-26187, which changed
> splits/merges to write directly into the daughter/merged region directory
> under the table dir.
> This patch:
> * Removes unused {{getRegionId(Path)}} and
> {{isTemporaryDirectoryName(String)}}
> * Marks {{REGION_SPLITS_DIR}} and {{REGION_MERGES_DIR}} as {{@Deprecated}}
> (since 3.0.0, will be removed in 4.0.0)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
