liuxiaocs7 commented on code in PR #8331:
URL: https://github.com/apache/hbase/pull/8331#discussion_r3392882463
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionFileSystem.java:
##########
@@ -78,10 +78,20 @@ public class HRegionFileSystem {
/** Name of the region info file that resides just under the region
directory. */
public final static String REGION_INFO_FILE = ".regioninfo";
- /** Temporary subdirectory of the region directory used for merges. */
+ /**
+ * Temporary subdirectory of the region directory used for merges.
+ * @deprecated Since 3.0.0, will be removed in 4.0.0. Merges now write
directly to the merged
+ * region directory under the table dir since HBASE-26187.
+ */
+ @Deprecated
public static final String REGION_MERGES_DIR = ".merges";
- /** Temporary subdirectory of the region directory used for splits. */
+ /**
+ * Temporary subdirectory of the region directory used for splits.
+ * @deprecated Since 3.0.0, will be removed in 4.0.0. Splits now write
directly to the daughter
+ * region directory under the table dir since HBASE-26187.
+ */
+ @Deprecated
public static final String REGION_SPLITS_DIR = ".splits";
Review Comment:
Thanks for your comments, agree with your points, I've removed the two
constants directly. The only usage was in `TestHdfsSnapshotHRegion`, which I've
updated to use string literals with a comment explaining they represent legacy
directories from before HBASE-26187.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
