Apache9 commented on PR #8353: URL: https://github.com/apache/hbase/pull/8353#issuecomment-4725178393
> > Where are the intern calls now? > > Back to the "BlockCacheKey(String hfileName, String cfName, String regionName, long offset, boolean isPrimaryReplica, BlockType blockType, boolean archived)" (lines 99 to 101). OK, I missed your previous comment about keeping the intern calls inside BlockCacheKey. I'm OK with moving the intern calls out if there are benefits, the only concern is to also move the StringPools out. If you think keeping it in BlockCacheKey is not the biggest bottleneck here I'm also OK with keeping it as is. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
