[ 
https://issues.apache.org/jira/browse/HBASE-30227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18089999#comment-18089999
 ] 

Xiao Liu commented on HBASE-30227:
----------------------------------

Pushed to all active branches.

Thanks [~wchevreuil], [~lupeng] and [~zhangduo] for reviewing!

> Disallow JUnit4 imports in source code
> --------------------------------------
>
>                 Key: HBASE-30227
>                 URL: https://issues.apache.org/jira/browse/HBASE-30227
>             Project: HBase
>          Issue Type: Improvement
>          Components: pom, test
>            Reporter: Xiao Liu
>            Assignee: Xiao Liu
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 2.7.0, 3.0.0-beta-2, 2.5.16, 2.6.7
>
>
> HBASE-30200 removed JUnit4 dependencies and added dependency bans, but HBase 
> source code can still accidentally import \{{org.junit.Assert}} because we 
> keep a test-scope shim for third-party JUnit4-compatible utilities.
> Add restrictImports rules to ban JUnit4 source imports such as 
> \{{org.junit.Assert}}, \{{org.junit.Assume}}, and related JUnit4 packages, 
> while keeping the shim available for compatibility.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to