[
https://issues.apache.org/jira/browse/HBASE-29912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18090467#comment-18090467
]
Hudson commented on HBASE-29912:
--------------------------------
Results for branch branch-2.5
[build #835 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/835/]:
(x) *{color:red}-1 overall{color}*
----
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/835/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/835/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/835/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/835/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk17 hadoop3 checks{color}
-- For more information [see jdk17
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/835/JDK17_20Nightly_20Build_20Report_20_28Hadoop3_29/]
> Codel lifoThreshold should be applied on soft queue limit instead of hard
> limit
> -------------------------------------------------------------------------------
>
> Key: HBASE-29912
> URL: https://issues.apache.org/jira/browse/HBASE-29912
> Project: HBase
> Issue Type: Bug
> Components: rpc
> Affects Versions: 3.0.0-beta-1, 2.6.4, 2.5.13
> Reporter: Umesh Kumar Kumawat
> Assignee: Umesh Kumar Kumawat
> Priority: Major
> Labels: pull-request-available
>
> Codel switch from fifo to lifo and it does this when queue size reached an
> threshold.
> For now codel lifoThreshold is applied on hard limit. By default soft limit
> of the queue remains 100 (10 handler per queue
> (CALL_QUEUE_HANDLER_FACTOR_CONF_KEY) and we use
> DEFAULT_MAX_CALLQUEUE_LENGTH_PER_HANDLER is 10). And 250 is hard limit.
> This way we are never achiving out desired behaviour.
>
> In this Jira we will also reduce CALL_QUEUE_CODEL_DEFAULT_TARGET_DELAY to 5ms.
> I think that after HBASE-16089 codel target delay was changed to 100, that is
> not standard for CoDel ([^HBASE-16089.v3.patch]). I have changed it back.
> To visualize why we should have 5 target delay with 100 interval, I used the
> [model|https://github.com/Umeshkumar9414/hbase/blob/0056886fb540ca1cfd9035aec489a3106c47bc09/hbase-server/src/main/resources/hbase-webapps/queue-simulator/adaptive-lifo-codel-simulator.html],
> With target delay 100 and interval 100 we are more prone the queue being
> full, although CoDel will be still helpful in LIFO mode but a full queue is
> problem as it can cause OOM.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
