Copilot commented on code in PR #8404:
URL: https://github.com/apache/hbase/pull/8404#discussion_r3464427836
##########
hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestBulkLoadReplication.java:
##########
@@ -130,8 +130,8 @@ public static void setUpBeforeAll() throws Exception {
ReplicationPeerConfig peer1Config = getPeerConfigForCluster(UTIL1);
ReplicationPeerConfig peer2Config = getPeerConfigForCluster(UTIL2);
ReplicationPeerConfig peer3Config = getPeerConfigForCluster(UTIL3);
- // Setup following topology: "1 <-> 2 <-> 3", 1 -> 2 will be added by
setUpBase method in parent
- // class
+ // Setup following topology: "1 <-> 2 <-> 3"
Review Comment:
Grammar: this comment should use the verb form “Set up …” (two words) for
readability and consistency with other comments.
##########
hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestBulkLoadReplication.java:
##########
@@ -162,13 +162,19 @@ private static void startThirdCluster() throws Exception {
}
@BeforeEach
- public void resetBulkLoadCount() throws Exception {
+ @Override
+ public void setUpBase() throws Exception {
// removing the peer and adding again causing the previously completed
bulk load jobs getting
// submitted again, so here we override the setUpBase and tearDownBase to
not adding/removing
// peers between each tests, we will add peers in beforeAll
Review Comment:
Grammar in this comment is a bit unclear (e.g., “removing … causing”, “to
not adding/removing”, “between each tests”). Rewording it will make the intent
easier to follow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
