liuxiaocs7 commented on code in PR #8420:
URL: https://github.com/apache/hbase/pull/8420#discussion_r3485929609
##########
hbase-server/src/test/java/org/apache/hadoop/hbase/client/CloneSnapshotFromClientAfterSplittingRegionWithLinksTestBase.java:
##########
@@ -121,12 +121,13 @@ public void
testClonedTableWithLinksSurvivesSourceDeletion() throws Exception {
// so the snapshot contains only HFileLinks and no Reference files.
int numRegions = admin.getRegions(tableName).size();
admin.split(tableName, SPLIT_KEY);
- await().atMost(Duration.ofSeconds(60)).untilAsserted(
+ await().atMost(Duration.ofSeconds(30)).untilAsserted(
Review Comment:
Hi, @guluo2016, thanks for the comments.
The `60s` was just an arbitrary upper bound from the original HBASE-30241
fix. I lowered it to `30s` to match the analogous
`CloneSnapshotFromClientAfterSplittingRegionTestBase`, which uses the same
`await().atMost(30s)` for the identical split-completion check. `await()`
returns as soon as the condition holds, so it's only a ceiling.
It's unrelated to the actual flaky fix though, unify the code in master and
branch-3 with the code in branch-2.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
