Copilot commented on code in PR #8442:
URL: https://github.com/apache/hbase/pull/8442#discussion_r3501370613
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityScanDeleteTracker.java:
##########
@@ -328,6 +328,20 @@ public DeleteResult isDeleted(ExtendedCell cell) {
return DeleteResult.NOT_DELETED;
}
+ /**
+ * The inherited {@link ScanDeleteTracker#isRedundantDelete(ExtendedCell)}
is label-blind: it
+ * tracks deleteCell/deleteType/deleteTimestamp (and familyStamp) without
regard to the visibility
+ * tags of the delete markers. Reusing it during minor compaction could drop
a delete marker that
+ * only shadows differently-labeled data, resurrecting cells that should
stay deleted. So on
+ * cell-authorization tables we conservatively report no delete as redundant
(matching the
+ * {@link org.apache.hadoop.hbase.regionserver.querymatcher.DeleteTracker}
default), keeping every
Review Comment:
Javadoc uses the term "cell-authorization tables", but this class and
surrounding context are about HBase cell-visibility (visibility labels). This
wording is confusing and looks inconsistent with the rest of the visibility
feature naming.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
