Umeshkumar9414 commented on code in PR #8389:
URL: https://github.com/apache/hbase/pull/8389#discussion_r3503049499
##########
hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSource.java:
##########
@@ -244,6 +246,10 @@ public interface MetricsRegionServerSource extends
BaseSource, JvmPauseMonitorSo
String STOREFILE_SIZE_DESC = "Size of storefiles being served.";
String STOREFILE_SIZE_GROWTH_RATE_DESC =
"Bytes per second by which the size of storefiles being served grows.";
+ String STOREFILE_UNCOMPRESSED_SIZE_DESC = "Total uncompressed size of
storefiles being served.";
+ String STOREFILE_COMPRESSION_RATIO_DESC =
+ "Compression ratio of storefiles (compressed/uncompressed). Lower values
indicate better"
+ + " compression. Returns 1.0 when there is no data.";
Review Comment:
changed the way of ratio calculation. Now higher is better.
##########
hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapper.java:
##########
@@ -116,6 +116,17 @@ public interface MetricsRegionServerWrapper {
*/
long getStoreFileSize();
+ /**
+ * Get the total uncompressed size of the store files this region server is
serving from.
+ */
+ long getStoreFileUncompressedSize();
+
+ /**
+ * Get the compression ratio of store files on this region server. This is
the ratio of compressed
+ * on-disk size to uncompressed data size. Returns 1.0 when there is no data.
+ */
+ double getStoreFileCompressionRatio();
Review Comment:
changes the ratio calculation way. Now higher is better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
