petersomogyi commented on code in PR #157:
URL: https://github.com/apache/hbase-connectors/pull/157#discussion_r3550334891
##########
dev-support/jenkins/hbase-personality.sh:
##########
@@ -392,6 +403,10 @@ function spotless_rebuild
return 0
fi
+ if [[ "${repostatus}" = branch ]]; then
+ return 0
+ fi
Review Comment:
Why is this needed?
##########
dev-support/jenkins/hbase-personality.sh:
##########
@@ -30,6 +30,17 @@ function personality_modules
local extra=""
local MODULES=("${CHANGED_MODULES[@]}")
+ # When spark4 modules are in the changed set, activate the spark4 profile
+ # so the full reactor (including hbase-spark-pushdown_2.13) is built.
+ # The maven-enforcer-plugin in the spark4 profile requires JDK 17+.
+ if [[ "${MODULES[*]}" =~ spark4 ]]; then
Review Comment:
In a follow up ticket it would be good to have a 2 phase testing, one for
JDK8 and one for JDK17.
Now an incompatible change outside of spark4 module can break the spark4
build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
