taklwu commented on code in PR #8377:
URL: https://github.com/apache/hbase/pull/8377#discussion_r3581573345
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/HBaseServerBase.java:
##########
@@ -639,11 +650,35 @@ public void updateConfiguration() throws IOException {
LOG.info("Reloading the configuration from disk.");
// Reload the configuration from disk.
preUpdateConfiguration();
+ this.readOnlyTransitionBlocked.set(false);
+ this.blockingActiveClusterId.set(null);
conf.reloadConfiguration();
configurationManager.notifyAllObservers(conf);
+ this.checkForBlockedReadOnlyTransition();
postUpdateConfiguration();
}
+ protected Configuration blockReadOnlyTransition(Configuration updatedConf,
+ String activeClusterId) {
+ this.blockingActiveClusterId.set(activeClusterId);
+ LOG.error(
+ "Cannot disable read-only mode. The {} file contains a different cluster
ID ({}), which means "
+ + "that cluster is already the active cluster. Reverting {} to true",
+ HConstants.ACTIVE_CLUSTER_SUFFIX_FILE_NAME,
this.blockingActiveClusterId.get(),
+ HConstants.HBASE_GLOBAL_READONLY_ENABLED_KEY);
Review Comment:
the checkstyle didn't fail, so, this is not related
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
