guluo2016 commented on code in PR #8468:
URL: https://github.com/apache/hbase/pull/8468#discussion_r3629489712
##########
hbase-common/src/main/resources/hbase-default.xml:
##########
@@ -1964,6 +1964,7 @@ possible configurations would overwhelm and obscure the
important.
<value>300000</value>
<description>
Timeout for regionservers to keep threads in snapshot request pool
waiting.
+ Must be greater than 0.
Review Comment:
Thanks for your contribution. Sorry for the delayed review.
I think we should add a comment here to clarify that
hbase.snapshot.region.timeout must be greater than 0.
https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/snapshot/RegionServerSnapshotManager.java#L89-L90
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
