[
https://issues.apache.org/jira/browse/HBASE-6409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13450135#comment-13450135
]
Andrew Wang commented on HBASE-6409:
------------------------------------
Hey Elliot,
Peeked at your changes to MutableQuantiles. You don't actually need to have
{{setChanged()}} in {{add()}}, since the metric only changes when it's rolled
over by the rollover thread. Besides that, I see you swapped out the
ScheduledExecutorService for MetricsService, which I assume does the same thing.
Is that what you wanted a check for?
> Create histogram class for metrics 2
> ------------------------------------
>
> Key: HBASE-6409
> URL: https://issues.apache.org/jira/browse/HBASE-6409
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 0.96.0
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Priority: Blocker
> Attachments: HBASE-6409-0.patch, HBASE-6409-1.patch,
> HBASE-6409-2.patch, HBASE-6409-3.patch
>
>
> Create the replacement for MetricsHistogram and PersistantTimeVaryingRate
> classes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira