taklwu commented on code in PR #8512:
URL: https://github.com/apache/hbase/pull/8512#discussion_r3685673323
##########
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/IncrementalBackupManager.java:
##########
@@ -184,10 +184,10 @@ private List<String> getLogFilesForNewBackup(Map<String,
Long> olderTimestamps,
}
// Include the .oldlogs files too.
- FileStatus[] oldlogs = fs.listStatus(oldLogDir);
- for (FileStatus oldlog : oldlogs) {
- p = oldlog.getPath();
- currentLogFile = p.toString();
+ List<String> oldlogs = BackupUtils.getFiles(fs, oldLogDir, new
ArrayList<>(), path -> true);
Review Comment:
can you double check if `BackupUtils#parseHostFromOldLog` would need to be
changed when `hbase.separate.oldlogdir.by.regionserver=true` ? basically I
checked the logic that when `hbase.separate.oldlogdir.by.regionserver=true` ,
there may have archived file without the host:port but the host name is part of
the directory , e.g.
`oldWALs/10.0.0.1,60030,1700000000000/wal.00000000000000000001`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
