[
https://issues.apache.org/jira/browse/HBASE-29962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18101217#comment-18101217
]
mazhengxuan commented on HBASE-29962:
-------------------------------------
Hi, I traced this back to HBASE-26048. The replacement for the deprecated
{{ThreadGroup.destroy()}} retained the old ERROR level, although the
HBASE-26048 discussion described this as a “check and warn”.
{{ProcedureExecutor.join()}} also treats non-terminated executor tasks as WARN.
I propose changing only this log from ERROR to WARN, while keeping the
active-thread check and {{threadGroup.list()}} diagnostic output. Would this
approach be acceptable?
> Misleading Error log in master branch
> -------------------------------------
>
> Key: HBASE-29962
> URL: https://issues.apache.org/jira/browse/HBASE-29962
> Project: HBase
> Issue Type: Bug
> Components: master
> Affects Versions: 4.0.0-alpha-1
> Reporter: rstest
> Priority: Major
>
> I recently rolling upgrade hbase from 2.6.4 to the master branch, and see one
> ERROR log in the master node:
> {code:java}
> ERROR [master/hmaster:16000] procedure2.ProcedureExecutor: There are still
> active thread in group java.lang.ThreadGroup[name=PEWorkerGroup,maxpri=10],
> see STDOUT {code}
> However when I check the code that introducing this log, it shows:
> {code:java}
> // log the still active threads, ThreadGroup.destroy is deprecated in
> JDK17 and it is not
> // necessary for us to must destroy it here, so we just do a check and log
> if (threadGroup.activeCount() > 0) {
> LOG.error("There are still active thread in group {}, see STDOUT",
> threadGroup);
> threadGroup.list();
> } {code}
> Like the comment says, if " ThreadGroup.destroy is deprecated in JDK17 and it
> is not necessary for us to must destroy it here, so we just do a check and
> log", should here be a warn log or even info log, instead of error log?
>
> I can attach a patch if changing to warn/info sounds reasonable to you.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
