chaijunjie0101 commented on code in PR #8519:
URL: https://github.com/apache/hbase/pull/8519#discussion_r3704296482
##########
hbase-server/src/test/java/org/apache/hadoop/hbase/rsgroup/TestRSGroupsFallback.java:
##########
@@ -93,10 +94,12 @@ public void testFallback() throws Exception {
// server of test group crash, regions move to default group
crashRsInGroup(groupName);
assertRegionsInGroup(tableName, RSGroupInfo.DEFAULT_GROUP);
+ assertEquals(0, MASTER.balance().getMovesCalculated());
// server of default group crash, regions move to any other group
crashRsInGroup(RSGroupInfo.DEFAULT_GROUP);
assertRegionsInGroup(tableName, FALLBACK_GROUP);
+ assertEquals(0, MASTER.balance().getMovesCalculated());
Review Comment:
> Thanks, good catch. `movesCalculated` is also zero when the balancer is
skipped, so the previous assertion could pass without `balanceCluster` actually
running.
>
> I updated the test to capture the `BalanceResponse` from the same balance
invocation, assert `isBalancerRan()` first, and then assert that
`getMovesCalculated()` is zero for both fallback cases.
great！need HBase's committer to help review and approve, if you have time,
please check and review this PR @guluo2016
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
