Copilot commented on code in PR #8485:
URL: https://github.com/apache/hbase/pull/8485#discussion_r3717791642
##########
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestSeekOptimizations.java:
##########
@@ -198,6 +206,7 @@ private void testScan(final int[] columnArr, final boolean
lazySeekEnabled, fina
final long initialSeekCount = StoreFileScanner.getSeekCount();
final InternalScanner scanner = region.getScanner(scan);
+ final long scannerOpenSeekCount = StoreFileScanner.getSeekCount() -
initialSeekCount;
final List<Cell> results = new ArrayList<>();
final List<Cell> actualKVs = new ArrayList<>();
Review Comment:
`InternalScanner` opened in `testScan` is never closed. This can leak
resources/WAL readers across the many scan iterations in this test class and
can also skew seek-count instrumentation between runs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
