terrytlu commented on PR #6947: URL: https://github.com/apache/hbase/pull/6947#issuecomment-5202949597
Hi @Apache9, sorry for the ping. I wanted to follow up on this PR — I believe all the points from your last review have now been addressed: Hi @Apache9, sorry for the ping. I wanted to follow up on this PR — I believe all the points from your last review have now been addressed: 1. **`SnapshotRegionSizeCalculator`** has been reworked into a utility class exposing a static `calculateRegionSizes()` method that returns a `RegionSizes` data structure, and the class is marked `@InterfaceAudience.Private`. 2. **On the active release branches**, the old public constructor is kept but properly **deprecated** with javadoc + lifecycle notes, per your suggestion to deprecate first and remove in 4.0.0. The "since" versions follow the current release lines listed on [hbase.apache.org/downloads](https://hbase.apache.org/downloads/): - branch-2.5 → [#8492](https://github.com/apache/hbase/pull/8492) (`@deprecated since 2.5.16`) - branch-2.6 → [#8493](https://github.com/apache/hbase/pull/8493) (`@deprecated since 2.6.7`) - branch-3.0 → [#8494](https://github.com/apache/hbase/pull/8494) (`@deprecated since 3.0.1`) All marked to be **removed in 4.0.0**. 3. **On master**, since it targets a future major release, the old constructor is removed directly and the `InputSplit.getLength()` now returns the real snapshot region size (no longer 0). 4. The test case now covers both scenarios (empty table → region size 0, non-empty table → region size > 0), as guluo2016 suggested. Could you take another look when you have a moment? Thanks! 🙏 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
