charlesconnell commented on code in PR #8542:
URL: https://github.com/apache/hbase/pull/8542#discussion_r3741020522
##########
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/BackupInfo.java:
##########
@@ -516,8 +528,13 @@ public static BackupInfo fromProto(BackupProtos.BackupInfo
proto) {
context.setState(BackupInfo.BackupState.valueOf(proto.getBackupState().name()));
}
- context
- .setHLogTargetDir(BackupUtils.getLogBackupDir(proto.getBackupRootDir(),
proto.getBackupId()));
+ // Only incremental backups have a WAL target directory. Setting this
unconditionally would
+ // hand FULL backups a non-null path that never existed, which
cleanupHLogDir() would then
+ // try to delete.
+ if (BackupType.valueOf(proto.getBackupType().name()) ==
BackupType.INCREMENTAL) {
+ context.setHLogTargetDir(
Review Comment:
While I don't believe this is true, in the interest of keeping this PR as
easy to understand as possible, I'm going to revert this line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
