Sigma-Ma commented on code in PR #8555: URL: https://github.com/apache/hbase/pull/8555#discussion_r3836092386
########## hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java: ########## Review Comment: Good catch. You're right — an existence-only Get can produce a Result with both exists and QueryMetrics, and this early return drops the metrics. I checked the related paths and found the same problem in toResultNoData, both protobuf-to-Result overloads when hasExists() is set, and the standalone Get response path in RSRpcServices, which currently serializes only the existence boolean. I'll update these paths and add an existence-only round-trip test. Table#exists itself will remain unchanged since that API returns only a boolean. Thanks for catching this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
