Sigma-Ma opened a new pull request, #8562: URL: https://github.com/apache/hbase/pull/8562
JIRA: https://issues.apache.org/jira/browse/HBASE-30054 ## What changes were proposed in this pull request? This patch prevents non-complete backup sessions from participating in cascading backup deletion. `BackupAdminImpl#getAffectedBackupSessions` now returns no affected sessions unless the backup being deleted is in the `COMPLETE` state. `TestIncrementalBackupWithFailures` was extended to create a successful incremental backup after failed incremental backup attempts, delete one of the failed backups, and verify that the successful backup remains complete with its table list intact. ## Why are the changes needed? A failed backup is not part of the committed backup chain because the backup system table is restored before the `FAILED` backup record is written. However, deleting a failed backup currently runs the same affected-session calculation used for completed backups. As a result, newer successful incremental backups can be treated as dependent backups and have their metadata or backup image removed. Only completed backups can have later backups depending on them. Skipping the cascading calculation for non-complete backups allows the failed backup itself to be cleaned up without affecting later valid backups. ## How was this patch tested? ```bash mvn -pl hbase-backup -am \ -Dtest=TestIncrementalBackupWithFailures \ -Dsurefire.failIfNoSpecifiedTests=false \ test ``` The test covers a completed full backup, failed incremental backup attempts, a later completed incremental backup, and deletion of a failed backup. It verifies that the failed backup record is removed and that the later completed backup remains available with both tables. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
