Sigma-Ma commented on code in PR #8563:
URL: https://github.com/apache/hbase/pull/8563#discussion_r3840478130
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/master/MetricsMasterWrapperImpl.java:
##########
@@ -180,6 +183,18 @@ public long getNumWALFiles() {
return master.getNumWALFiles();
}
+ @Override
+ public long getOldestProcedureAge() {
Review Comment:
Good point, thanks. A LockProcedure can naturally live much longer, so the
global max may hide a stuck procedure of another type.
I updated the patch to calculate the oldest age per procedure class and
expose gauges such as `oldestProcedureAge_LockProcedure` and
`oldestProcedureAge_ServerCrashProcedure`. I kept `oldestProcedureAge` as the
overall max for the original use case.
The test now covers two procedure types, multiple procedures of the same
type, and finished procedures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
