sercanCyberVision commented on PR #8569: URL: https://github.com/apache/hbase/pull/8569#issuecomment-5443908817
@guluo2016, please find the changes: 1. As you suggested, I set the timeout duration to 5 seconds for the third scan attempt to return. 2. As Copilot suggested, I extended the `try/catch/finally` block scope to cover all scan attempts, so that if something goes wrong earlier in the test, `allowScanToFinish` can still be released in the `finally` block. 3. As Copilot suggested, I set a 15-second timeout for `allowScanToFinish` in `scanForReport()`. This gives the test enough time to complete all three scan attempts, including the 5-second timeout of the third scan in the negative test case, before `allowScanToFinish` is released in the `finally` block. I executed both the positive and negative test cases again. In the negative test case, on the build side: ``` [ERROR] org.apache.hadoop.hbase.master.janitor.TestCatalogJanitor.testAlreadyRunningStatusDoesNotClearLock -- Time elapsed: 7.471 s <<< FAILURE! org.opentest4j.AssertionFailedError: execution timed out after 5000 ms ``` On the logs side: ``` 2026-08-27T14:51:30,021 ERROR [HBase-Test-TestCatalogJanitor-Main-Thread] janitor.TestCatalogJanitor(743): Third catalog janitor scan did not return -1 within 5 seconds; the scan may be running instead of returning -1. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
