kgeisz commented on code in PR #8517:
URL: https://github.com/apache/hbase/pull/8517#discussion_r3919226454
##########
dev-support/read-replica/Dockerfile:
##########
@@ -0,0 +1,131 @@
+# Stage 0: Cache Maven dependencies
+ARG BASE_IMAGE=registry.access.redhat.com/ubi8/openjdk-17:1.23
+FROM ${BASE_IMAGE} AS cache-stage
Review Comment:
`hadolint` is not giving me this warning when I run it locally. Maybe the
linter being used here cannot parse `${BASE_IMAGE}`. I added `hadolint
ignore=DL3006` to these `FROM ${BASE_IMAGE}` lines to suppress the warning.
Also, in case you didn't notice, I chose to ignore some other warnings as
well. Let me know if you want me to address these.
```
# hadolint ignore=DL3002 to suppress:
./Dockerfile:11 DL3041 warning: Specify version with `dnf install -y
<package>-<version>`.
./Dockerfile:35 DL3041 warning: Specify version with `dnf install -y
<package>-<version>`.
./Dockerfile:70 DL3041 warning: Specify version with `dnf install -y
<package>-<version>`.
# hadolint ignore=DL3002 to suppress:
./Dockerfile:8 DL3002 warning: Last USER should not be root
./Dockerfile:33 DL3002 warning: Last USER should not be root
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
