virajjasani commented on code in PR #8622:
URL: https://github.com/apache/hbase/pull/8622#discussion_r3960374157


##########
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/OpenRegionProcedure.java:
##########
@@ -127,7 +127,12 @@ protected void 
updateTransitionWithoutPersistingToMeta(MasterProcedureEnv env,
 
   @Override
   protected void restoreSucceedState(AssignmentManager am, RegionStateNode 
regionNode,
-    long openSeqNum) throws IOException {
+    TransitionCode transitionCode, long openSeqNum) throws IOException {
+    if (transitionCode == TransitionCode.FAILED_OPEN) {
+      // will not persist to meta if giveUp is false, matches the live 
reportTransition path

Review Comment:
   Is `FAILED_OPEN` the only case where we have this problem? What about 
split/merge reverted states?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to