Copilot commented on code in PR #164: URL: https://github.com/apache/hbase-connectors/pull/164#discussion_r3971486670
########## dev-support/jenkins/Dockerfile: ########## @@ -17,7 +17,7 @@ # Dockerfile for hbase-connectors pre-commit build. # https://builds.apache.org/job/PreCommit-HBASE-CONNECTORS-Build -FROM maven:3.8-jdk-8 +FROM maven:3.8-eclipse-temurin-8 Review Comment: The `maven:3.9-eclipse-temurin-8` tag is a floating tag and can change over time (including Maven patch updates and base OS changes), which can make CI runs non-reproducible and introduce sudden breakages. Consider pinning to a more specific Maven patch version (and ideally an image digest) to improve build determinism. ########## dev-support/jenkins/Jenkinsfile: ########## @@ -40,7 +40,7 @@ pipeline { YETUS_DRIVER_REL = "${SRC_REL}/dev-support/jenkins/jenkins_precommit_github_yetus.sh" ARCHIVE_PATTERN_LIST = 'TEST-*.xml,org.apache.h*.txt,*.dumpstream,*.dump' BUILD_URL_ARTIFACTS = "artifact/${WORKDIR_REL}/${PATCH_REL}" - SET_JAVA_HOME = '/usr/local/openjdk-8' + SET_JAVA_HOME = '/opt/java/openjdk' Review Comment: Hardcoding `SET_JAVA_HOME` to a specific filesystem path makes the pipeline tightly coupled to the container image layout. If the image already sets `JAVA_HOME`, consider deriving `SET_JAVA_HOME` from `JAVA_HOME` (or documenting why this override is required) to reduce future churn when the base image changes again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
