wchevreuil commented on PR #163: URL: https://github.com/apache/hbase-connectors/pull/163#issuecomment-5618408700
> Thanks for the review. I addressed the remaining comments: > > * reverted the unrelated formatting changes; > * reused and closed Connection, Admin, Table, and RegionLocator in BulkLoadSuite; > * fixed the same connection leak pattern in the other bulk-load tests; > * replaced KeyAlreadyExistsException with IllegalArgumentException and corrected the message; > * reused the partition comparator and fixed the noted typos and style issues. > > I left the staging-directory test and Partitioner equals/hashCode unchanged, as they are not needed for this port. Can you push these changes? I don't see any commit in the PR branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
