kgeisz commented on code in PR #8638:
URL: https://github.com/apache/hbase/pull/8638#discussion_r3982084773
##########
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/HBackupFileSystem.java:
##########
@@ -158,11 +161,15 @@ public static List<BackupImage>
getAllBackupImages(Configuration conf, Path back
}
String backupId = lfs.getPath().getName();
+ if (HBASE_TEMP_DIRECTORY.equals(backupId)) {
+ continue;
+ }
+
Review Comment:
It looks like only the bulkoad directory (`backupRoot/.tmp/backup_XXXX`) was
getting deleted when an incremental backup finished:
https://github.com/apache/hbase/blob/master/hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/IncrementalTableBackupClient.java#L427
I added a new commit that deletes `backupRoot/.tmp` instead. Should we still
have `.tmp` get skipped over in the code here as well as a safeguard?
cc. @ankitsol
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
