PDavid commented on PR #163: URL: https://github.com/apache/hbase-thirdparty/pull/163#issuecomment-5636140753
### Testing Checked if the patches still apply cleanly by running `mvn clean process-sources -pl hbase-shaded-thrift -am` The output showed both patches applied with no errors: ``` [INFO] --- maven-patch-plugin:1.2:apply (patch) @ hbase-shaded-thrift --- [INFO] Applying patch: HBASE-30194-01-servlet-javax.patch [INFO] Applying patch: HBASE-30194-02-httpclient4.patch [INFO] ------------------------------------------------------------------------ ... [INFO] BUILD SUCCESS ``` Then run a full build with `mvn clean verify -pl hbase-shaded-thrift -am`, it was successful. Installed hbase-thirdparty to the local Maven repo with `mvn clean install -DskipTests` Then run a few Thrift tests in HBase, pointing it at our 4.1.15-SNAPSHOT thirdparty: ``` $ cd ../hbase $ mvn test -pl hbase-thrift -Dhbase-thirdparty.version=4.1.15-SNAPSHOT -Dtest="TestThriftServer,TestThriftHBaseServiceHandler,TestThriftHttpServer,TestThrift2HttpServer,TestThriftConnection" -Dsurefire.failIfNoSpecifiedTests=false [INFO] --- maven-surefire-plugin:3.5.3:test (default-test) @ hbase-thrift --- [INFO] Using auto detected provider org.apache.maven.surefire.junitplatform.JUnitPlatformProvider [INFO] [INFO] ------------------------------------------------------- [INFO] T E S T S [INFO] ------------------------------------------------------- [INFO] Running org.apache.hadoop.hbase.thrift2.TestThrift2HttpServer [INFO] Running org.apache.hadoop.hbase.thrift.TestThriftHttpServer [INFO] Running org.apache.hadoop.hbase.thrift2.TestThriftConnection [INFO] Running org.apache.hadoop.hbase.thrift2.TestThriftHBaseServiceHandler [INFO] Running org.apache.hadoop.hbase.thrift.TestThriftServer [WARNING] Tests run: 40, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 76.40 s -- in org.apache.hadoop.hbase.thrift2.TestThriftHBaseServiceHandler [INFO] Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 83.97 s -- in org.apache.hadoop.hbase.thrift2.TestThriftConnection [INFO] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 86.68 s -- in org.apache.hadoop.hbase.thrift.TestThriftServer [INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 134.7 s -- in org.apache.hadoop.hbase.thrift.TestThriftHttpServer [INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 135.3 s -- in org.apache.hadoop.hbase.thrift2.TestThrift2HttpServer [INFO] [INFO] Results: [INFO] [WARNING] Tests run: 63, Failures: 0, Errors: 0, Skipped: 1 [INFO] [INFO] [INFO] --- maven-surefire-plugin:3.5.3:test (secondPartTestsExecution) @ hbase-thrift --- [INFO] Tests are skipped. [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 02:22 min [INFO] Finished at: 2026-09-11T16:35:24+02:00 [INFO] ------------------------------------------------------------------------ ``` Tests were successful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
