junegunn commented on PR #8646: URL: https://github.com/apache/hbase/pull/8646#issuecomment-5689824392
Copilot's test suggestions were not relevant, and I'm confident that this PR is now ready for review. I also asked Codex to review the PR again and it commented: > One existing limitation remains: `hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/WALInputFormat.java:414` compares NameNode modification time against RegionServer entry timestamps. If the RegionServer clock is ahead, a closed, unarchived WAL can still lose in-range entries during filtering. This case also failed before the PR. While this is technically possible, I wouldn't worry too much about it in real-world HBase clusters, where NTP is a requirement. More importantly, this is an existing limitation and not a regression introduced by the PR. Could someone take a look at the patch? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
