wchevreuil commented on PR #8661: URL: https://github.com/apache/hbase/pull/8661#issuecomment-5698928434
> The resulting size mismatch can make cache validation or later block unpacking use an incorrect length, causing cache mismatches or read/decompression failures. Can you prove this? Also, there are other parts of the code that set "onDiskDataSizeWithHeader" within the checksum. If we would apply this proposal, we would probably break block comparison when checking the cache, for cacheOnRead, for example, potentially caching an already cached block again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
