Huginn-kio commented on PR #8664: URL: https://github.com/apache/hbase/pull/8664#issuecomment-5699328669
Updated the patch to follow the canonical balancer-assignment path used by the fix. The previous implementation manually iterated `RegionStates#getRegionAssignments()`, so a region without a current location could be represented by a null `ServerName` in the RSGroup balancer input. The patch now: 1. Collects the online servers that belong to the requested RSGroup. 2. Delegates assignment collection to `RegionStates#getAssignmentsForBalancer(...)`. 3. Applies the existing community table-to-RSGroup resolution when selecting the returned tables, including the implicit membership of the default group. This removes null server keys from the balancer input and reuses the common eligibility handling for null locations, disabled/disabling tables, and regions that are not OPEN or OPENING. The regression test covers a region with no current server and preserves disabled-table filtering. Local validation: - `TestRSGroupsBalance`: 4 tests passed - Targeted Checkstyle: 0 violations - RAT: passed - SpotBugs: 0 bugs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
