Sigma-Ma commented on code in PR #8623:
URL: https://github.com/apache/hbase/pull/8623#discussion_r4028047794
##########
hbase-common/src/main/java/org/apache/hadoop/hbase/util/VersionInfo.java:
##########
@@ -40,15 +40,12 @@ public class VersionInfo {
// higher than any numbers in the version.
private static final int VERY_LARGE_NUMBER = 100000;
- // Copying into a non-final member so that it can be changed by reflection
for testing
- private static String version = Version.version;
-
/**
* Get the hbase version.
* @return the hbase version string, eg. "0.6.3-dev"
*/
public static String getVersion() {
- return version;
Review Comment:
This mutable field was introduced only to let the test override the version
through reflection. Since the test now simulates the lower version through
HMaster, the field is no longer needed, so getVersion() can return
Version.version directly again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
