liuxiaocs7 commented on code in PR #8625:
URL: https://github.com/apache/hbase/pull/8625#discussion_r4037610776


##########
hbase-common/src/test/java/org/apache/hadoop/hbase/logging/TestJul2Slf4j.java:
##########
@@ -37,8 +37,8 @@
 import org.mockito.stubbing.Answer;
 
 /**
- * This should be in the hbase-logging module but the {@link 
HBaseClassTestRule} is in hbase-common

Review Comment:
   Hi, @Apache9, thanks for the comments. I had planned to address this in a 
follow-up issue, since retaining `HBaseJupiterExtension` would introduce a 
circular dependency: `hbase-common` already depends on `hbase-logging`. Would 
you prefer moving the tests here without the extension, or addressing this 
together in a follow-up?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to