taklwu commented on code in PR #8676:
URL: https://github.com/apache/hbase/pull/8676#discussion_r4048905591
##########
dev-support/read-replica/.env:
##########
Review Comment:
so, are we always use default? or `kgeisz` is being used?
I'm thinking if we should make it more like `default` instead of using a
user like prefix.
##########
dev-support/read-replica/.env:
##########
@@ -22,7 +22,7 @@ HBASE_CONTAINER_NAME=hbase-docker
# This is the host running the hbase-docker containers. Use localhost if the
containers
# are running locally. If they are started by another container, such as a
Jenkins
# container in a Docker-out-of-Docker setup, then try setting this to
host.docker.internal.
-HBASE_HOST=${HBASE_HOST:-localhost}
+HBASE_HOST=${HBASE_HOST:-host.docker.internal}
Review Comment:
seems like you can use it in `build-images.sh` line #21 and overwrite the
hostname? or is it how the `.env` is being used?
```
. ./.env
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
