Copilot commented on code in PR #8691: URL: https://github.com/apache/hbase/pull/8691#discussion_r4080470420
########## hbase-website/app/pages/_docs/docs/_mdx/(multi-page)/configuration/basic-prerequisites.mdx: ########## @@ -22,29 +29,39 @@ The following table summarizes the recommendations of the HBase community with r JVM. When selecting your JDK distribution, please take this into consideration. </Callout> -**Java support by release line** - -| HBase Version | JDK 6 | JDK 7 | JDK 8 | JDK 11 | JDK 17 | -| :-----------: | :---: | :---: | :---: | :----: | :----: | -| HBase 2.6 | ❌ | ❌ | ✅ | ✅ | ✅ | -| HBase 2.5 | ❌ | ❌ | ✅ | ✅ | ⚠️\* | -| HBase 2.4 | ❌ | ❌ | ✅ | ✅ | ❌ | -| HBase 2.3 | ❌ | ❌ | ✅ | ⚠️\* | ❌ | -| HBase 2.0-2.2 | ❌ | ❌ | ✅ | ❌ | ❌ | -| HBase 1.2+ | ❌ | ✅ | ✅ | ❌ | ❌ | -| HBase 1.0-1.1 | ❌ | ✅ | ⚠️ | ❌ | ❌ | -| HBase 0.98 | ✅ | ✅ | ⚠️ | ❌ | ❌ | -| HBase 0.94 | ✅ | ✅ | ❌ | ❌ | ❌ | +### Java support by release line + +| HBase Version | JDK 6 | JDK 7 | JDK 8 | JDK 11 | JDK 17 | JDK 21 | Review Comment: The table header cell for “JDK 21” includes extra padding spaces. Some MDX/Markdown renderers treat superfluous spacing in table cells inconsistently (especially when combined with alignment markers). Consider changing the header text to plain `JDK 21` (no extra padding) to avoid formatting/rendering drift. ########## hbase-website/app/pages/_docs/docs/_mdx/(multi-page)/configuration/basic-prerequisites.mdx: ########## @@ -22,29 +29,39 @@ The following table summarizes the recommendations of the HBase community with r JVM. When selecting your JDK distribution, please take this into consideration. </Callout> -**Java support by release line** - -| HBase Version | JDK 6 | JDK 7 | JDK 8 | JDK 11 | JDK 17 | -| :-----------: | :---: | :---: | :---: | :----: | :----: | -| HBase 2.6 | ❌ | ❌ | ✅ | ✅ | ✅ | -| HBase 2.5 | ❌ | ❌ | ✅ | ✅ | ⚠️\* | -| HBase 2.4 | ❌ | ❌ | ✅ | ✅ | ❌ | -| HBase 2.3 | ❌ | ❌ | ✅ | ⚠️\* | ❌ | -| HBase 2.0-2.2 | ❌ | ❌ | ✅ | ❌ | ❌ | -| HBase 1.2+ | ❌ | ✅ | ✅ | ❌ | ❌ | -| HBase 1.0-1.1 | ❌ | ✅ | ⚠️ | ❌ | ❌ | -| HBase 0.98 | ✅ | ✅ | ⚠️ | ❌ | ❌ | -| HBase 0.94 | ✅ | ✅ | ❌ | ❌ | ❌ | +### Java support by release line + +| HBase Version | JDK 6 | JDK 7 | JDK 8 | JDK 11 | JDK 17 | JDK 21 | +| :-----------: | :---: | :---: | :---: | :----: | :----: | :---------: | +| HBase 3.1 | ❌ | ❌ | ❌ | ❌ | ✅ | ✅ | +| HBase 3.0 | ❌ | ❌ | ❌ | ❌ | ✅ | ✅ (3.0.1+) | +| HBase 2.7 | ❌ | ❌ | ✅ | ✅ | ✅ | ✅ | +| HBase 2.6 | ❌ | ❌ | ✅ | ✅ | ✅ | ✅ (2.6.8+) | +| HBase 2.5 | ❌ | ❌ | ✅ | ✅ | ⚠️ | ⚠️ | +| HBase 2.4 | ❌ | ❌ | ✅ | ✅ | ❌ | ❌ | +| HBase 2.3 | ❌ | ❌ | ✅ | ⚠️ | ❌ | ❌ | +| HBase 2.0-2.2 | ❌ | ❌ | ✅ | ❌ | ❌ | ❌ | +| HBase 1.2+ | ❌ | ✅ | ✅ | ❌ | ❌ | ❌ | +| HBase 1.0-1.1 | ❌ | ✅ | ⚠️ | ❌ | ❌ | ❌ | +| HBase 0.98 | ✅ | ✅ | ⚠️ | ❌ | ❌ | ❌ | +| HBase 0.94 | ✅ | ✅ | ❌ | ❌ | ❌ | ❌ | <Callout type="warn"> -Preliminary support for JDK11 is introduced with HBase 2.3.0, and for JDK17 is introduced with HBase 2.5.x. We will compile and run test suites with JDK11/17 in pre commit checks and nightly checks. We will mark the support as ✅ as long as we have run some ITs with the JDK version and also there are users in the community use the JDK version in real production clusters. +Preliminary support for JDK 11 was introduced with HBase 2.3.0, and for JDK 17 with HBase 2.5.x. JDK 11 and JDK 17 have precommit and nightly coverage on applicable branches. We mark support as ✅ after running some integration tests with that JDK version and confirming that community members use it in production clusters. For JDK11/JDK17 support in HBase, please refer to [HBASE-22972](https://issues.apache.org/jira/browse/HBASE-22972) and [HBASE-26038](https://issues.apache.org/jira/browse/HBASE-26038) Review Comment: The surrounding text has been updated to use spaced forms like “JDK 11” / “JDK 17”, but this line still uses “JDK11/JDK17”. For readability and consistency within this section, update this to “JDK 11/JDK 17” (or “JDK 11 and JDK 17”). ########## hbase-website/app/pages/_docs/docs/_mdx/(multi-page)/configuration/basic-prerequisites.mdx: ########## @@ -22,29 +29,39 @@ The following table summarizes the recommendations of the HBase community with r JVM. When selecting your JDK distribution, please take this into consideration. </Callout> -**Java support by release line** - -| HBase Version | JDK 6 | JDK 7 | JDK 8 | JDK 11 | JDK 17 | -| :-----------: | :---: | :---: | :---: | :----: | :----: | -| HBase 2.6 | ❌ | ❌ | ✅ | ✅ | ✅ | -| HBase 2.5 | ❌ | ❌ | ✅ | ✅ | ⚠️\* | -| HBase 2.4 | ❌ | ❌ | ✅ | ✅ | ❌ | -| HBase 2.3 | ❌ | ❌ | ✅ | ⚠️\* | ❌ | -| HBase 2.0-2.2 | ❌ | ❌ | ✅ | ❌ | ❌ | -| HBase 1.2+ | ❌ | ✅ | ✅ | ❌ | ❌ | -| HBase 1.0-1.1 | ❌ | ✅ | ⚠️ | ❌ | ❌ | -| HBase 0.98 | ✅ | ✅ | ⚠️ | ❌ | ❌ | -| HBase 0.94 | ✅ | ✅ | ❌ | ❌ | ❌ | +### Java support by release line + +| HBase Version | JDK 6 | JDK 7 | JDK 8 | JDK 11 | JDK 17 | JDK 21 | +| :-----------: | :---: | :---: | :---: | :----: | :----: | :---------: | +| HBase 3.1 | ❌ | ❌ | ❌ | ❌ | ✅ | ✅ | +| HBase 3.0 | ❌ | ❌ | ❌ | ❌ | ✅ | ✅ (3.0.1+) | +| HBase 2.7 | ❌ | ❌ | ✅ | ✅ | ✅ | ✅ | +| HBase 2.6 | ❌ | ❌ | ✅ | ✅ | ✅ | ✅ (2.6.8+) | +| HBase 2.5 | ❌ | ❌ | ✅ | ✅ | ⚠️ | ⚠️ | +| HBase 2.4 | ❌ | ❌ | ✅ | ✅ | ❌ | ❌ | +| HBase 2.3 | ❌ | ❌ | ✅ | ⚠️ | ❌ | ❌ | +| HBase 2.0-2.2 | ❌ | ❌ | ✅ | ❌ | ❌ | ❌ | +| HBase 1.2+ | ❌ | ✅ | ✅ | ❌ | ❌ | ❌ | +| HBase 1.0-1.1 | ❌ | ✅ | ⚠️ | ❌ | ❌ | ❌ | +| HBase 0.98 | ✅ | ✅ | ⚠️ | ❌ | ❌ | ❌ | +| HBase 0.94 | ✅ | ✅ | ❌ | ❌ | ❌ | ❌ | <Callout type="warn"> -Preliminary support for JDK11 is introduced with HBase 2.3.0, and for JDK17 is introduced with HBase 2.5.x. We will compile and run test suites with JDK11/17 in pre commit checks and nightly checks. We will mark the support as ✅ as long as we have run some ITs with the JDK version and also there are users in the community use the JDK version in real production clusters. +Preliminary support for JDK 11 was introduced with HBase 2.3.0, and for JDK 17 with HBase 2.5.x. JDK 11 and JDK 17 have precommit and nightly coverage on applicable branches. We mark support as ✅ after running some integration tests with that JDK version and confirming that community members use it in production clusters. Review Comment: Terminology is inconsistent: this uses “precommit” and “precommit checks”, while earlier text historically used “pre-commit”/“pre commit”. Standardizing the term (preferably “pre-commit”, unless the project style guide explicitly prefers “precommit”) will make the CI-coverage statements clearer and more searchable across docs. ########## hbase-website/app/pages/_docs/docs/_mdx/(multi-page)/configuration/basic-prerequisites.mdx: ########## @@ -22,29 +29,39 @@ The following table summarizes the recommendations of the HBase community with r JVM. When selecting your JDK distribution, please take this into consideration. </Callout> -**Java support by release line** - -| HBase Version | JDK 6 | JDK 7 | JDK 8 | JDK 11 | JDK 17 | -| :-----------: | :---: | :---: | :---: | :----: | :----: | -| HBase 2.6 | ❌ | ❌ | ✅ | ✅ | ✅ | -| HBase 2.5 | ❌ | ❌ | ✅ | ✅ | ⚠️\* | -| HBase 2.4 | ❌ | ❌ | ✅ | ✅ | ❌ | -| HBase 2.3 | ❌ | ❌ | ✅ | ⚠️\* | ❌ | -| HBase 2.0-2.2 | ❌ | ❌ | ✅ | ❌ | ❌ | -| HBase 1.2+ | ❌ | ✅ | ✅ | ❌ | ❌ | -| HBase 1.0-1.1 | ❌ | ✅ | ⚠️ | ❌ | ❌ | -| HBase 0.98 | ✅ | ✅ | ⚠️ | ❌ | ❌ | -| HBase 0.94 | ✅ | ✅ | ❌ | ❌ | ❌ | +### Java support by release line + +| HBase Version | JDK 6 | JDK 7 | JDK 8 | JDK 11 | JDK 17 | JDK 21 | +| :-----------: | :---: | :---: | :---: | :----: | :----: | :---------: | +| HBase 3.1 | ❌ | ❌ | ❌ | ❌ | ✅ | ✅ | +| HBase 3.0 | ❌ | ❌ | ❌ | ❌ | ✅ | ✅ (3.0.1+) | +| HBase 2.7 | ❌ | ❌ | ✅ | ✅ | ✅ | ✅ | +| HBase 2.6 | ❌ | ❌ | ✅ | ✅ | ✅ | ✅ (2.6.8+) | +| HBase 2.5 | ❌ | ❌ | ✅ | ✅ | ⚠️ | ⚠️ | +| HBase 2.4 | ❌ | ❌ | ✅ | ✅ | ❌ | ❌ | +| HBase 2.3 | ❌ | ❌ | ✅ | ⚠️ | ❌ | ❌ | +| HBase 2.0-2.2 | ❌ | ❌ | ✅ | ❌ | ❌ | ❌ | +| HBase 1.2+ | ❌ | ✅ | ✅ | ❌ | ❌ | ❌ | +| HBase 1.0-1.1 | ❌ | ✅ | ⚠️ | ❌ | ❌ | ❌ | +| HBase 0.98 | ✅ | ✅ | ⚠️ | ❌ | ❌ | ❌ | +| HBase 0.94 | ✅ | ✅ | ❌ | ❌ | ❌ | ❌ | <Callout type="warn"> -Preliminary support for JDK11 is introduced with HBase 2.3.0, and for JDK17 is introduced with HBase 2.5.x. We will compile and run test suites with JDK11/17 in pre commit checks and nightly checks. We will mark the support as ✅ as long as we have run some ITs with the JDK version and also there are users in the community use the JDK version in real production clusters. +Preliminary support for JDK 11 was introduced with HBase 2.3.0, and for JDK 17 with HBase 2.5.x. JDK 11 and JDK 17 have precommit and nightly coverage on applicable branches. We mark support as ✅ after running some integration tests with that JDK version and confirming that community members use it in production clusters. For JDK11/JDK17 support in HBase, please refer to [HBASE-22972](https://issues.apache.org/jira/browse/HBASE-22972) and [HBASE-26038](https://issues.apache.org/jira/browse/HBASE-26038) For JDK11/JDK17 support in Hadoop, which may also affect HBase, please refer to [HADOOP-15338](https://issues.apache.org/jira/browse/HADOOP-15338) and [HADOOP-17177](https://issues.apache.org/jira/browse/HADOOP-17177) </Callout> +<Callout type="info" title="JDK 21 support"> +See [HBASE-29546](https://issues.apache.org/jira/browse/HBASE-29546) for JDK 21 compatibility work and [HBASE-30354](https://issues.apache.org/jira/browse/HBASE-30354) for nightly coverage. HBase's precommit checks do not yet test JDK 21. + +JDK 21 validation for HBase 2.5 remains incomplete. Review Comment: The matrix refers to release lines (e.g., “HBase 2.5”), and elsewhere you use “2.5.x”. To avoid implying only the single 2.5.0 release, consider rewording to “HBase 2.5.x” (or “the HBase 2.5 line”) here as well. ########## hbase-website/app/pages/_docs/docs/_mdx/(multi-page)/configuration/basic-prerequisites.mdx: ########## @@ -22,29 +29,39 @@ The following table summarizes the recommendations of the HBase community with r JVM. When selecting your JDK distribution, please take this into consideration. </Callout> -**Java support by release line** - -| HBase Version | JDK 6 | JDK 7 | JDK 8 | JDK 11 | JDK 17 | -| :-----------: | :---: | :---: | :---: | :----: | :----: | -| HBase 2.6 | ❌ | ❌ | ✅ | ✅ | ✅ | -| HBase 2.5 | ❌ | ❌ | ✅ | ✅ | ⚠️\* | -| HBase 2.4 | ❌ | ❌ | ✅ | ✅ | ❌ | -| HBase 2.3 | ❌ | ❌ | ✅ | ⚠️\* | ❌ | -| HBase 2.0-2.2 | ❌ | ❌ | ✅ | ❌ | ❌ | -| HBase 1.2+ | ❌ | ✅ | ✅ | ❌ | ❌ | -| HBase 1.0-1.1 | ❌ | ✅ | ⚠️ | ❌ | ❌ | -| HBase 0.98 | ✅ | ✅ | ⚠️ | ❌ | ❌ | -| HBase 0.94 | ✅ | ✅ | ❌ | ❌ | ❌ | +### Java support by release line + +| HBase Version | JDK 6 | JDK 7 | JDK 8 | JDK 11 | JDK 17 | JDK 21 | +| :-----------: | :---: | :---: | :---: | :----: | :----: | :---------: | +| HBase 3.1 | ❌ | ❌ | ❌ | ❌ | ✅ | ✅ | +| HBase 3.0 | ❌ | ❌ | ❌ | ❌ | ✅ | ✅ (3.0.1+) | +| HBase 2.7 | ❌ | ❌ | ✅ | ✅ | ✅ | ✅ | +| HBase 2.6 | ❌ | ❌ | ✅ | ✅ | ✅ | ✅ (2.6.8+) | +| HBase 2.5 | ❌ | ❌ | ✅ | ✅ | ⚠️ | ⚠️ | +| HBase 2.4 | ❌ | ❌ | ✅ | ✅ | ❌ | ❌ | +| HBase 2.3 | ❌ | ❌ | ✅ | ⚠️ | ❌ | ❌ | +| HBase 2.0-2.2 | ❌ | ❌ | ✅ | ❌ | ❌ | ❌ | +| HBase 1.2+ | ❌ | ✅ | ✅ | ❌ | ❌ | ❌ | +| HBase 1.0-1.1 | ❌ | ✅ | ⚠️ | ❌ | ❌ | ❌ | +| HBase 0.98 | ✅ | ✅ | ⚠️ | ❌ | ❌ | ❌ | +| HBase 0.94 | ✅ | ✅ | ❌ | ❌ | ❌ | ❌ | <Callout type="warn"> -Preliminary support for JDK11 is introduced with HBase 2.3.0, and for JDK17 is introduced with HBase 2.5.x. We will compile and run test suites with JDK11/17 in pre commit checks and nightly checks. We will mark the support as ✅ as long as we have run some ITs with the JDK version and also there are users in the community use the JDK version in real production clusters. +Preliminary support for JDK 11 was introduced with HBase 2.3.0, and for JDK 17 with HBase 2.5.x. JDK 11 and JDK 17 have precommit and nightly coverage on applicable branches. We mark support as ✅ after running some integration tests with that JDK version and confirming that community members use it in production clusters. For JDK11/JDK17 support in HBase, please refer to [HBASE-22972](https://issues.apache.org/jira/browse/HBASE-22972) and [HBASE-26038](https://issues.apache.org/jira/browse/HBASE-26038) For JDK11/JDK17 support in Hadoop, which may also affect HBase, please refer to [HADOOP-15338](https://issues.apache.org/jira/browse/HADOOP-15338) and [HADOOP-17177](https://issues.apache.org/jira/browse/HADOOP-17177) </Callout> +<Callout type="info" title="JDK 21 support"> +See [HBASE-29546](https://issues.apache.org/jira/browse/HBASE-29546) for JDK 21 compatibility work and [HBASE-30354](https://issues.apache.org/jira/browse/HBASE-30354) for nightly coverage. HBase's precommit checks do not yet test JDK 21. Review Comment: Terminology is inconsistent: this uses “precommit” and “precommit checks”, while earlier text historically used “pre-commit”/“pre commit”. Standardizing the term (preferably “pre-commit”, unless the project style guide explicitly prefers “precommit”) will make the CI-coverage statements clearer and more searchable across docs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
