hgromer commented on code in PR #8694:
URL: https://github.com/apache/hbase/pull/8694#discussion_r4173741155
##########
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/FullTableBackupClient.java:
##########
@@ -208,14 +215,17 @@ private void handleContinuousBackup(Admin admin) throws
IOException {
}
private void handleNonContinuousBackup(Admin admin) throws IOException {
+ Map<String, Long> previousLogRollsByHost =
backupManager.readRegionServerLastLogRollResult();
performLogRoll();
+ Map<String, Long> latestLogRollsByHost = newTimestamps;
performBackupSnapshots(admin);
backupManager.addIncrementalBackupTableSet(backupInfo.getTables());
// set overall backup status: complete. Here we make sure to complete the
backup.
// After this checkpoint, even if entering cancel process, will let the
backup finished
backupInfo.setState(BackupState.COMPLETE);
+ adjustTimestampsForOfflineHosts(previousLogRollsByHost,
latestLogRollsByHost);
Review Comment:
I've moved when this happens, and will actually let this throw now, because
it's early enough a failure won't mess up the state. Falling back to existing
newTimestamps exposes the data loss bugs, so I think a loud failure is warranted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
