virajjasani commented on code in PR #8738:
URL: https://github.com/apache/hbase/pull/8738#discussion_r4188775710
##########
dev-support/hbase_docker/build-hbase.sh:
##########
@@ -336,6 +352,35 @@ main() {
local value=""
local image_name="$DEFAULT_IMAGE_NAME"
+ # Extract --jdk (position-independent); the rest stays positional
+ local args=()
+ while [ $# -gt 0 ]; do
+ case "$1" in
+ --jdk)
+ if [ $# -lt 2 ] || [ -z "$2" ]; then
+ echo "❌ ERROR: --jdk requires a value (supported: $SUPPORTED_JDKS)"
+ exit 1
+ fi
+ JDK_VERSION="$2"
+ shift 2
+ ;;
+ --jdk=*)
+ JDK_VERSION="${1#--jdk=}"
+ shift
+ ;;
+ *)
+ args+=("$1")
+ shift
+ ;;
+ esac
+ done
+ set -- "${args[@]+"${args[@]}"}"
+
+ if [[ " $SUPPORTED_JDKS " != *" $JDK_VERSION "* ]]; then
+ echo "❌ ERROR: Unsupported JDK version: $JDK_VERSION (supported:
$SUPPORTED_JDKS)"
Review Comment:
Same here
##########
dev-support/hbase_docker/build-hbase.sh:
##########
@@ -336,6 +352,35 @@ main() {
local value=""
local image_name="$DEFAULT_IMAGE_NAME"
+ # Extract --jdk (position-independent); the rest stays positional
+ local args=()
+ while [ $# -gt 0 ]; do
+ case "$1" in
+ --jdk)
+ if [ $# -lt 2 ] || [ -z "$2" ]; then
+ echo "❌ ERROR: --jdk requires a value (supported: $SUPPORTED_JDKS)"
Review Comment:
Can we remove cross checkmark from echo?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
