Sigma-Ma commented on code in PR #8578:
URL: https://github.com/apache/hbase/pull/8578#discussion_r4244241588


##########
hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestSyncReplicationStandbyKillMaster.java:
##########
@@ -108,6 +108,10 @@ public void testStandbyKillMaster() throws Exception {
     await().atMost(Duration.ofMinutes(3))
       .untilAsserted(() -> assertEquals(SyncReplicationState.DOWNGRADE_ACTIVE,
         UTIL2.getAdmin().getReplicationPeerSyncReplicationState(PEER_ID)));
+    await().atMost(Duration.ofMinutes(3))

Review Comment:
   Thank you for the suggestion. I've added a comment explaining why the 
Master-side state check can pass before the RegionServer refresh completes, and 
why the additional wait is needed before verifying the data.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to