[ 
https://issues.apache.org/jira/browse/HBASE-6658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13452687#comment-13452687
 ] 

Lars Hofhansl commented on HBASE-6658:
--------------------------------------

Patch looks good. +1
A small technicality... Should we "svn move" the file, so it retains its 
history?
(Not sure that is possible to express with a patch, but it can be done in 
SVN... I think :) )
                
> Rename WritableByteArrayComparable to something not mentioning Writable
> -----------------------------------------------------------------------
>
>                 Key: HBASE-6658
>                 URL: https://issues.apache.org/jira/browse/HBASE-6658
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Gregory Chanan
>            Assignee: Gregory Chanan
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: HBASE-6658.patch, HBASE-6658-v3.patch, 
> HBASE-6658-v4.patch, HBASE-6658-v5.patch, HBASE-6658-v6.patch
>
>
> After HBASE-6477, WritableByteArrayComparable will no longer be Writable, so 
> should be renamed.
> Current idea is ByteArrayComparator (since all the derived classes are 
> *Comparator not *Comparable), but I'm open to suggestions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to