VladRodionov commented on PR #8801:
URL: https://github.com/apache/hbase/pull/8801#issuecomment-6531110144
Addressed review comments:
- I restored RegionServer-level `CacheAccessService` registration coverage in
`TestRegionServerOnlineConfigChange`.
- I restored graceful-stop behavior in `HRegion.close()` so `evictOnClose`
is disabled only for the
same case as before: an exclusive tiered cache with a persistent
`BucketCache` as L2.
- I fixed `blockCacheLevel.jsp` handling of `IndexOnlyLRU` by recognizing
legacy
`LruBlockCache` implementations wrapped by `BlockCacheBackedCacheEngine`.
- I restricted public test-only `LruCacheEngine` accessors with
`@RestrictedApi`.
- I added cache-engine accessors to `CacheAccessService` and removed
concrete-service branching from
`HeapMemoryManager`, `MetricsRegionServerWrapperImpl`, and the
RegionServer cache UI code.
Callers now use `getFirstLevelEngine()` / `getEngine(CacheTier)` instead
of inspecting
`TopologyBackedCacheAccessService` or `BlockCacheBackedCacheAccessService`.
- I removed the unreachable RegionServer-specific
`BlockCacheBackedCacheAccessService` handling as a
consequence of the common engine-access API.
- I cleaned up JSP whitespace issues reported by review: mixed tabs/spaces,
trailing whitespace, and
missing final newlines.
Almost all nits.
Not addressed in this commit:
- I did not preserve the old `HBaseTestingUtility` methods taking
`BlockCache` by adding compatibility
overloads. The long-term goal of the migration is to remove `BlockCache`
references, so retaining
new compatibility APIs would work against that goal.
- The resulting public API signature change in deprecated
`HBaseTestingUtility` will need to be
called out in the release note when the complete cache migration is merged
to master.
- I did not attempt to remove every remaining `BlockCache` reference. Legacy
cache implementations
and adapters remain where needed until the rest of the migration is
completed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
