[
https://issues.apache.org/jira/browse/HBASE-30495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18136293#comment-18136293
]
Xiao Liu commented on HBASE-30495:
----------------------------------
Pushed to all active branches.
Thanks [~zhangduo] for reviewing!
> Incorrect remote RPC retry count when reopening a scanner
> ---------------------------------------------------------
>
> Key: HBASE-30495
> URL: https://issues.apache.org/jira/browse/HBASE-30495
> Project: HBase
> Issue Type: Bug
> Components: Client
> Reporter: Xiao Liu
> Assignee: Xiao Liu
> Priority: Minor
> Labels: pull-request-available
> Fix For: 4.0.0-alpha-1, 2.7.0, 3.1.0, 3.0.1, 2.6.8, 2.5.17
>
>
> {\{AsyncScanSingleRegionRpcRetryingCaller.completeWhenError}} passes
> \{{closeScanner}} to \{{incRPCRetriesMetrics}}, but the method expects
> whether the RegionServer is remote.
> This causes:
> * Remote retries to be undercounted when the scanner is already closed, e.g.
> after \{{ScannerResetException}}.
> * Local retries to be incorrectly counted as remote when the scanner needs
> closing, e.g. after \{{OutOfOrderScannerNextException}}.
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
