liuxiaocs7 commented on code in PR #8824:
URL: https://github.com/apache/hbase/pull/8824#discussion_r4439416515
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java:
##########
@@ -511,16 +520,26 @@ public String toString() {
@Override
public void onConfigurationChange(Configuration conf) {
- cacheDataOnRead = conf.getBoolean(CACHE_DATA_ON_READ_KEY,
DEFAULT_CACHE_DATA_ON_READ);
- cacheDataOnWrite = conf.getBoolean(CACHE_BLOCKS_ON_WRITE_KEY,
DEFAULT_CACHE_DATA_ON_WRITE);
- evictOnClose = conf.getBoolean(EVICT_BLOCKS_ON_CLOSE_KEY,
DEFAULT_EVICT_ON_CLOSE);
+ updateCacheSettings(conf);
LOG.info(
"Config hbase.block.data.cacheonread is changed to {}, "
+ "hbase.rs.cacheblocksonwrite is changed to {}, "
+ "hbase.rs.evictblocksonclose is changed to {}",
cacheDataOnRead, cacheDataOnWrite, evictOnClose);
Review Comment:
Addressed in 86bd36fc802: the log message now reports these as the effective
cache settings instead of saying the config keys changed to these values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
