Sigma-Ma commented on code in PR #174:
URL: https://github.com/apache/hbase-connectors/pull/174#discussion_r4488885878
##########
spark4/hbase-spark4/src/test/scala/org/apache/hadoop/hbase/spark/datasources/HBaseTableProviderSuite.scala:
##########
@@ -1013,4 +1043,181 @@ class HBaseTableProviderSuite extends AnyFunSuite with
BeforeAndAfterAll with Lo
connection.close()
}
}
+
+ private def checkTypeAwarePredicates(
+ name: String,
+ dataType: String,
+ values: Seq[Any],
+ predicates: Seq[String],
+ rowKey: Boolean,
+ avro: Boolean = false): Unit = {
+ val testTable = TableName.valueOf(s"type_aware_${name}_${if (rowKey) "key"
else "column"}")
Review Comment:
The current cases do not collide, so I'd keep the deterministic names for
this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
