arvindKandpal-ksolves opened a new pull request, #8852:
URL: https://github.com/apache/hbase/pull/8852
### Problem
The hbtop usage showed -D options after the other options:
usage: hbase hbtop [opts] [-D<property=value>]*
But -D only works before the other options. ToolRunner stops reading generic
options at the first tool option, so following the usage fails:
$ hbase hbtop -b -n 1 -Dhbase.client.retries.number=1
ERROR hbtop.HBTop: Unable to parse options
UnrecognizedOptionException: Unrecognized option:
-Dhbase.client.retries.number=1
The help and the hbtop doc page also only showed a ZooKeeper example
(`-Dhbase.client.zookeeper.quorum`). Since 3.0 the default registry is
RpcConnectionRegistry, which does not read that key.
### Changes
- `HBTop.java`: usage is now `hbase hbtop [-D<property=value>]* [opts]`,
with a note that -D must come first. The help shows
`hbase.client.bootstrap.servers` for the default registry and keeps the
ZooKeeper example for `ZKConnectionRegistry`.
- `hbtop.mdx`: same correction, with a note on which registry is the default
before and since 3.0.
### Testing
- hbase-hbtop unit tests pass. No new test, since only help text and docs
changed.
- On a local standalone cluster, both examples print the hbtop summary and
region rows, and the old order still fails with UnrecognizedOptionException.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
